fix: Add proper returns when parsing fails in miner

zhangsoledad · Apr 10, 2019 · f37cf2c · f37cf2c
1 parent 9925d4e
commit f37cf2c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/miner/src/miner.rs b/miner/src/miner.rs
@@ -74,24 +74,28 @@ impl Miner {
             let uncles = uncles.into_iter().map(TryInto::try_into).collect();
             if let Err(ref e) = uncles {
                 error!(target: "miner", "error parsing uncles: {:?}", e);
+                return None;
             }
             let cellbase = cellbase.try_into();
             if let Err(ref e) = cellbase {
                 error!(target: "miner", "error parsing cellbase: {:?}", e);
+                return None;
             }
             let commit_transactions = commit_transactions
                 .into_iter()
                 .map(TryInto::try_into)
                 .collect();
             if let Err(ref e) = commit_transactions {
                 error!(target: "miner", "error parsing commit transactions: {:?}", e);
+                return None;
             }
             let proposal_transactions = proposal_transactions
                 .into_iter()
                 .map(TryInto::try_into)
                 .collect();
             if let Err(ref e) = proposal_transactions {
                 error!(target: "miner", "error parsing proposal transactions: {:?}", e);
+                return None;
             }
 
             let block = BlockBuilder::default()