conn_get_header: return NULL if not found

Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
zhaojh329 · Jul 2, 2020 · 162b8fe · 162b8fe
1 parent 2844706
commit 162b8fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/connection.c b/src/connection.c
@@ -212,7 +212,7 @@ static const char *conn_get_header(struct uh_connection *conn, const char *name)
     }
 
     if (i == UHTTPD_MAX_HEADER_NUM)
-        return "";
+        return NULL;
 
     for (j = 0; j < UHTTPD_MAX_HEADER_NUM; j++) {
         if (req->headers_info[j].name_offset > 0) {
@@ -226,7 +226,7 @@ static const char *conn_get_header(struct uh_connection *conn, const char *name)
         }
     }
 
-    return "";
+    return NULL;
 }
 
 static const char *conn_get_body(struct uh_connection *conn, int *len)

diff --git a/src/file.c b/src/file.c
@@ -88,7 +88,7 @@ static void file_response_304(struct uh_connection *conn, struct stat *s)
 static bool file_if_modified_since(struct uh_connection *conn, struct stat *s)
 {
     const char *hdr = conn->get_header(conn, "If-Modified-Since");
-    if (!hdr[0])
+    if (!hdr)
         return true;
 
     if (date2unix(hdr) >= s->st_mtime) {
@@ -101,8 +101,7 @@ static bool file_if_modified_since(struct uh_connection *conn, struct stat *s)
 
 static bool file_if_range(struct uh_connection *conn, struct stat *s)
 {
-    const char *hdr = conn->get_header(conn, "If-Range");
-    if (hdr[0]) {
+    if (conn->get_header(conn, "If-Range")) {
         conn->error(conn, HTTP_STATUS_PRECONDITION_FAILED, NULL);
         return false;
     }
@@ -113,7 +112,7 @@ static bool file_if_range(struct uh_connection *conn, struct stat *s)
 static bool file_if_unmodified_since(struct uh_connection *conn, struct stat *s)
 {
     const char *hdr = conn->get_header(conn, "If-Modified-Since");
-    if (hdr[0] && date2unix(hdr) <= s->st_mtime) {
+    if (hdr && date2unix(hdr) <= s->st_mtime) {
         conn->error(conn, HTTP_STATUS_PRECONDITION_FAILED, NULL);
         return false;
     }