fix(file): call sync via exec to avoid breaking the loop event.

Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>
zhaojh329 · Nov 25, 2023 · a60b9ca · a60b9ca
1 parent f007ede
commit a60b9ca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/file.c b/file.c
@@ -434,12 +434,6 @@ static int eco_file_basename(lua_State *L)
     return 1;
 }
 
-static int eco_file_sync(lua_State *L)
-{
-    sync();
-    return 0;
-}
-
 static int eco_file_flock(lua_State *L)
 {
     int fd = luaL_checkinteger(L, 1);
@@ -472,7 +466,6 @@ static const luaL_Reg funcs[] = {
     {"chown", eco_file_chown},
     {"dirname", eco_file_dirname},
     {"basename", eco_file_basename},
-    {"sync", eco_file_sync},
     {"flock", eco_file_flock},
     {NULL, NULL}
 };

diff --git a/file.lua b/file.lua
@@ -105,4 +105,15 @@ function M.flock(fd, operation, timeout)
     end
 end
 
+function M.sync()
+    local pid, err = sys.exec('sync')
+    if not pid then
+        return nil, err
+    end
+
+    eco.watcher(eco.CHILD, pid):wait()
+
+    return true
+end
+
 return setmetatable(M, { __index = file })