feat(core): expand native filter hook and add chart metadata fields (a…

…pache#943)

* refactor: update setExtraFormData hook / change isNativeFilter Property / remove native filters

* refactor: clear storybook

* refactor: update type place

* refactor: add dasourceCount property

* refactor: fix CR notes

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/chart/models/ChartMetadata.ts

@@ -1,3 +1,5 @@
+import { Behavior } from '../types/Base';
+
 interface LookupTable {
   [key: string]: boolean;
 }
@@ -7,11 +9,12 @@ export interface ChartMetadataConfig {
   canBeAnnotationTypes?: string[];
   credits?: string[];
   description?: string;
+  datasourceCount?: number;
   show?: boolean;
   supportedAnnotationTypes?: string[];
   thumbnail: string;
   useLegacyApi?: boolean;
-  isNativeFilter?: boolean;
+  behaviors?: Behavior[];
 }
 
 export default class ChartMetadata {
@@ -33,7 +36,9 @@ export default class ChartMetadata {
 
   useLegacyApi: boolean;
 
-  isNativeFilter: boolean;
+  behaviors: Behavior[];
+
+  datasourceCount: number;
 
   constructor(config: ChartMetadataConfig) {
     const {
@@ -45,7 +50,8 @@ export default class ChartMetadata {
       supportedAnnotationTypes = [],
       thumbnail,
       useLegacyApi = false,
-      isNativeFilter = false,
+      behaviors = [],
+      datasourceCount = 1,
     } = config;
 
     this.name = name;
@@ -65,7 +71,8 @@ export default class ChartMetadata {
     this.supportedAnnotationTypes = supportedAnnotationTypes;
     this.thumbnail = thumbnail;
     this.useLegacyApi = useLegacyApi;
-    this.isNativeFilter = isNativeFilter;
+    this.behaviors = behaviors;
+    this.datasourceCount = datasourceCount;
   }
 
   canBeAnnotationType(type: string): boolean {
@@ -82,7 +89,8 @@ export default class ChartMetadata {
       supportedAnnotationTypes: this.supportedAnnotationTypes,
       thumbnail: this.thumbnail,
       useLegacyApi: this.useLegacyApi,
-      isNativeFilter: this.isNativeFilter,
+      behaviors: this.behaviors,
+      datasourceCount: this.datasourceCount,
     });
   }
 }

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/chart/types/Base.ts

@@ -2,8 +2,19 @@ import { ExtraFormData } from '../../query';
 
 export type HandlerFunction = (...args: unknown[]) => void;
 
+export enum Behavior {
+  CROSS_FILTER = 'CROSS_FILTER',
+  NATIVE_FILTER = 'NATIVE_FILTER',
+}
+
 export type SetExtraFormDataHook = {
-  (extraFormData: ExtraFormData): void;
+  ({
+    extraFormData,
+    currentState: { value },
+  }: {
+    extraFormData: ExtraFormData;
+    currentState: { value: any; [key: string]: any };
+  }): void;
 };
 
 export interface PlainObject {