feat: adds the option to show values for mixed time-series (apache#1435)

zhaoyongjie · Nov 17, 2021 · 8aece1c · 8aece1c
1 parent 3cf4273
commit 8aece1c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/...superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx b/...superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx
@@ -42,6 +42,7 @@ const {
   orderDesc,
   rowLimit,
   seriesType,
+  showValues,
   stack,
   truncateYAxis,
   yAxisBounds,
@@ -165,6 +166,18 @@ function createCustomizeSection(label: string, controlSuffix: string): ControlSe
         },
       },
     ],
+    [
+      {
+        name: `show_value${controlSuffix}`,
+        config: {
+          type: 'CheckboxControl',
+          label: t('Show Values'),
+          renderTrigger: true,
+          default: showValues,
+          description: t('Whether to display the numerical values within the cells'),
+        },
+      },
+    ],
     [
       {
         name: `opacity${controlSuffix}`,

diff --git a/...uperset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts b/...uperset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
@@ -34,7 +34,7 @@ import {
   EchartsMixedTimeseriesFormData,
   EchartsMixedTimeseriesChartTransformedProps,
 } from './types';
-import { ForecastSeriesEnum, ProphetValue } from '../types';
+import { ForecastSeriesEnum } from '../types';
 import { parseYAxisBound } from '../utils/controls';
 import {
   currentSeries,
@@ -91,6 +91,8 @@ export default function transformProps(
     seriesType,
     seriesTypeB,
     showLegend,
+    showValue,
+    showValueB,
     stack,
     stackB,
     truncateYAxis,
@@ -149,6 +151,7 @@ export default function transformProps(
       markerSize,
       areaOpacity: opacity,
       seriesType,
+      showValue,
       stack,
       yAxisIndex,
       filterState,
@@ -162,6 +165,7 @@ export default function transformProps(
       markerSize: markerSizeB,
       areaOpacity: opacityB,
       seriesType: seriesTypeB,
+      showValue: showValueB,
       stack: stackB,
       yAxisIndex: yAxisIndexB,
       filterState,
@@ -281,8 +285,7 @@ export default function transformProps(
         const prophetValue = !richTooltip ? [params] : params;
 
         const rows: Array<string> = [`${tooltipTimeFormatter(value)}`];
-        const prophetValues: Record<string, ProphetValue> =
-          extractProphetValuesFromTooltipParams(prophetValue);
+        const prophetValues = extractProphetValuesFromTooltipParams(prophetValue);
 
         Object.keys(prophetValues).forEach(key => {
           const value = prophetValues[key];

diff --git a/...mporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts b/...mporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/MixedTimeseries/types.ts
@@ -77,6 +77,8 @@ export type EchartsMixedTimeseriesFormData = QueryFormData & {
   rowLimitB: number;
   seriesType: EchartsTimeseriesSeriesType;
   seriesTypeB: EchartsTimeseriesSeriesType;
+  showValue: boolean;
+  showValueB: boolean;
   stack: boolean;
   stackB: boolean;
   yAxisIndex?: number;
@@ -117,6 +119,8 @@ export const DEFAULT_FORM_DATA: EchartsMixedTimeseriesFormData = {
   rowLimitB: TIMESERIES_DEFAULTS.rowLimit,
   seriesType: TIMESERIES_DEFAULTS.seriesType,
   seriesTypeB: TIMESERIES_DEFAULTS.seriesType,
+  showValue: TIMESERIES_DEFAULTS.showValue,
+  showValueB: TIMESERIES_DEFAULTS.showValue,
   stack: TIMESERIES_DEFAULTS.stack,
   stackB: TIMESERIES_DEFAULTS.stack,
   yAxisIndex: 0,