fix: update lineMulti when queryData changes (apache#782)

zhaoyongjie · Nov 24, 2021 · ca2c372 · ca2c372
1 parent ea22515
commit ca2c372
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/...rary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx b/...rary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx
@@ -68,11 +68,12 @@ class LineMulti extends React.Component {
     this.loadData(this.props);
   }
 
-  shouldComponentUpdate(nextProps) {
+  shouldComponentUpdate(nextProps, nextState) {
     const { rawFormData } = this.props;
     const { rawFormData: nextRawFormData } = nextProps;
     const { queryData } = this.state;
-    if (!queryData || !isEqual(rawFormData, nextRawFormData)) {
+    const { queryData: nextQueryData } = nextState;
+    if (!isEqual(queryData, nextQueryData) || !isEqual(rawFormData, nextRawFormData)) {
       return true;
     }