Configure Github Actions to post coverage on external PRs #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on the last PR that Github Actions is set to not upload coverage comments for external PRs (i.e. those from a fork). This is because there is only read-only access for external PRs.
This PR solves that problem and makes it possible for coverage comments to be displayed on external PRs as well. (See also second part of: py-cov-action/python-coverage-comment-action#15 (comment))
I would find it very helpful when developing if already when creating PRs it would be shown how the coverage changes. However, this is just a suggestion. If it doesn't suit your ideas on how coverage should be managed, feel free to close it.