Add bench command #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhelyabuzhsky the build tests are stuck on the pytest checks. This is because the benchmark function gets stuck. You may need to cancel these tests unless they have a timeout. |
|
This PR is now fixed and is ready for review. I have also fixed all the failing unit tests in this PR. |
ghost
marked this pull request as ready for review
ghost
commented
Dec 24, 2021
ghost
commented
Dec 24, 2021
ghost
commented
Dec 24, 2021
ghost
commented
Dec 24, 2021
zhelyabuzhsky
requested changes
Dec 29, 2021
Co-authored-by: Ilya Zhelyabuzhsky <zhelyabuzhsky@icloud.com>
Co-authored-by: Ilya Zhelyabuzhsky <zhelyabuzhsky@icloud.com>
zhelyabuzhsky
approved these changes
Dec 30, 2021
|
Great work, thank you @Pavocracy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is currently not 100% working. The bench command has been added with the benchmark function, but the bench command outputs to both stdout and stderr. I am having trouble getting stderr to be read properly. For me when testing locally it only outputs some of the stderr and then gets stuck and needs to be forcefully closed.
Any suggestions on getting this PR working would be greatly appreciated.
You can see how the bench command works here: https://github.com/official-stockfish/Stockfish/blob/master/src/uci.cpp