Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add btime and wtime options #85

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

janrnc
Copy link
Contributor

@janrnc janrnc commented Feb 26, 2022

As issued here, btime and wtime commands are useful in order to let the engine decide the time spent in searching for the best move.

As reported in the UCI description:

If one command is not sent its value should be interpreted as it would not influence the search.

So i thought that the use of optional arguments in the already existing get_best_move function would prevent from having lots of different methods for move searching.

@janrnc
Copy link
Contributor Author

janrnc commented Feb 26, 2022

Sorry for all these fix commits but stockfish output depends on the machine it runs on. Shouldn't we just test this wrapper instead of checking the actual engine output?

Seems that even from one run to another, on the same machine, the output can change and break the tests.

@janrnc
Copy link
Contributor Author

janrnc commented Feb 27, 2022

I've squashed these commits in order to not mess up with the history.

@zhelyabuzhsky zhelyabuzhsky merged commit a6c27cf into zhelyabuzhsky:master Mar 1, 2022
@zhelyabuzhsky
Copy link
Owner

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants