Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 92 fixes #93

Merged
merged 4 commits into from
May 31, 2022
Merged

Issue 92 fixes #93

merged 4 commits into from
May 31, 2022

Conversation

johndoknjas
Copy link
Contributor

Resolves #92.

  • Discard any remaining _stockfish.stdout lines, if a function is done reading but some lines are left over. Prevents the wdl bug mentioned in issue 92.
  • Get rid of '-' chars in the major version, in case there are any. Should fix the second bug mentioned in the issue.
  • Update the readme with some explanations in the parameters and major version sections.

@zhelyabuzhsky
Copy link
Owner

Thank you ) Good job

@zhelyabuzhsky zhelyabuzhsky merged commit cd81493 into zhelyabuzhsky:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

does_current_engine_version_have_wdl_option() not work on stockfish variant
2 participants
@johndoknjas @zhelyabuzhsky