fixed assertion of selenium text field value

zhimin · Jun 20, 2012 · 4724383 · 4724383
1 parent 275b06c
commit 4724383
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -1,3 +1,7 @@
+1.4.9 (2012-06-20)
+ - selenium: new select syntax
+ - selenium: assert text field value
+
 1.4.8 (2012-05-12)
  - support watir 3
 

diff --git a/build.xml b/build.xml
@@ -30,7 +30,7 @@
       <format property="today" pattern="yyyyMMdd"/>
     </tstamp>
     <!-- <buildnumber/> -->
-    <property name="versionNumber" value="1.4.8"/>
+    <property name="versionNumber" value="1.4.9"/>
     <echo message="Extension version: ${versionNumber}"/>
     <mkdir dir="${targetDir}"/>
     <mkdir dir="${targetDir}/chrome"/>

diff --git a/src/content/editors/selenium_webdriver_editor.js b/src/content/editors/selenium_webdriver_editor.js
@@ -142,14 +142,15 @@ conversions["setCheckbox"] = function(oStep)
 
 conversions["setSelectField"] = function(oStep)
 {
-  return 'select_elem = browser.' + identifyInputField(oStep) + ';' + 
-   "options = select_elem.find_elements(:tag_name, \"option\"); " + 
-   "options.each { |opt| opt.click if opt.text == \"" + oStep.text + "\"}"
+  // return 'select_elem = browser.' + identifyInputField(oStep) + ';' + 
+  //  "options = select_elem.find_elements(:tag_name, \"option\"); " + 
+  //  "options.each { |opt| opt.click if opt.text == \"" + oStep.text + "\"}"
+  return "Selenium::WebDriver::Support::Select.new(browser." + identifyInputField(oStep) + ").select_by(:text, \"" + oStep.text + "\")"
 }
 
 conversions["verifyInputField"] = function(oStep)
 {
-  var tagName = "browser.text_field";
+  var tagName = "browser.find_element";
   if (oStep.tagName == "TEXTAREA") {
     tagName = "browser.area";
   }