Create separate code generator package #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good idea. However I would move the codegen content directly in the generator module since the ninja templates are the resources of the generator and are not a separate module. |
markheik
force-pushed
the
generator_package
branch
from
faeac3b
to
8d52a21
Compare
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 40.70% 41.36% +0.65%
==========================================
Files 15 14 -1
Lines 624 573 -51
==========================================
- Hits 254 237 -17
+ Misses 370 336 -34
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create separate code generator package.