Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround on YOLOTransform to support fixed size input #109

Merged
merged 7 commits into from
May 20, 2021

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented May 20, 2021

This will introduce backward-incompatible updates, we use the size (Tuple[int, int]) parameter in YOLOModule instead of min_size (int) and max_size (int).

Ref: pytorch/vision@2d0f267

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #109 (2e61ea9) into master (97c8ab7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files           8        8           
  Lines         784      784           
=======================================
  Hits          655      655           
  Misses        129      129           
Flag Coverage Δ
unittests 83.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_engine.py 100.00% <100.00%> (ø)
test/test_onnx.py 87.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c8ab7...2e61ea9. Read the comment docs.

@zhiqwang zhiqwang added the enhancement New feature or request label May 20, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zhiqwang zhiqwang merged commit 66b8330 into master May 20, 2021
@zhiqwang zhiqwang deleted the fixed-sized-transform branch May 20, 2021 09:22
zhiqwang added a commit that referenced this pull request May 20, 2021
@zhiqwang zhiqwang added the API Library use interface label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Library use interface enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant