Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add letterbox for TRT inference #305

Merged
merged 4 commits into from
Feb 9, 2022

Conversation

ShiquanYu
Copy link
Contributor

@ShiquanYu ShiquanYu commented Feb 9, 2022

Image after letterbox and results:

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #305 (5ba9159) into main (ba6c637) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          11       11           
  Lines         731      731           
=======================================
  Hits          694      694           
  Misses         37       37           
Flag Coverage Δ
unittests 94.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6c637...5ba9159. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShiquanYu , the overall looks great to me, I only have some comments regarding the function name and the output class type of EfficientNMS_TRT plugin.

deployment/tensorrt/main.cpp Outdated Show resolved Hide resolved
deployment/tensorrt/main.cpp Outdated Show resolved Hide resolved
@ShiquanYu ShiquanYu changed the title Add letter box for TRT inference Add letterbox for TRT inference Feb 9, 2022
@zhiqwang zhiqwang added enhancement New feature or request deployment Inference acceleration for production labels Feb 9, 2022
@zhiqwang zhiqwang merged commit be343c5 into zhiqwang:main Feb 9, 2022
@ShiquanYu ShiquanYu deleted the feature/trt_letterbox branch February 17, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Inference acceleration for production enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants