Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves optional imports #366

Merged
merged 7 commits into from
Mar 17, 2022

Conversation

mattpopovich
Copy link
Contributor

@mattpopovich mattpopovich commented Mar 15, 2022

Fixes #353

@mattpopovich mattpopovich changed the title Improves optional imports, fixes #353 Improves optional imports Mar 15, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mattpopovich
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #366 (ea0291a) into main (3c14e91) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          11       11           
  Lines         778      778           
=======================================
  Hits          767      767           
  Misses         11       11           
Flag Coverage Δ
unittests 98.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c14e91...ea0291a. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattpopovich , the overall looks great to me! I only make one comment about where to place the decorator, let me know if you have more concerns.

yolort/runtime/trt_helper.py Outdated Show resolved Hide resolved
@zhiqwang zhiqwang added enhancement New feature or request code quality Code format and unit tests dependencies Pull requests that update a dependency file labels Mar 16, 2022
@zhiqwang
Copy link
Owner

Hi @mattpopovich , since #369 introduces some conflicts, I rebase this PR manually, and please use the following command to synchronize with the current branch:

git pull --rebase origin improve-optional-imports

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks GREAT to me, thanks @mattpopovich for your great contributions here! And I'm merging this PR!

@zhiqwang zhiqwang merged commit bf05b4b into zhiqwang:main Mar 17, 2022
@mattpopovich mattpopovich deleted the improve-optional-imports branch March 17, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify error message if onnx_graphsurgeon is not installed?
3 participants