Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows compatibility for TensorRT C++ example #389

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Fix Windows compatibility for TensorRT C++ example #389

merged 6 commits into from
Apr 14, 2022

Conversation

Yoh-Z
Copy link
Contributor

@Yoh-Z Yoh-Z commented Apr 13, 2022 •
edited by zhiqwang

Nvidia Linux Windows yolort

Close #384

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 13, 2022 •
edited

Codecov Report

Merging #389 (57e6143) into main (8e715f2) will not change coverage.
The diff coverage is n/a.

❗ Current head 57e6143 differs from pull request most recent head 13d7e91. Consider uploading reports for the commit 13d7e91 to get more accurate results

@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          11       11           
  Lines         778      778           
=======================================
  Hits          767      767           
  Misses         11       11
Flag Coverage Δ
unittests 98.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e715f2...13d7e91. Read the comment docs.

@zhiqwang zhiqwang added the enhancement New feature or request label Apr 13, 2022
@ShiquanYu
Copy link
Contributor

啊正规，lgtm

zhiqwang
zhiqwang approved these changes Apr 14, 2022
View reviewed changes
Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT to me! Thanks @Yoh-Z and welcome to yolort community. I'm merging this PR.

@zhiqwang zhiqwang force-pushed the main branch 2 times, most recently from cb62874 to 8b1d88d Compare April 14, 2022 14:12
@zhiqwang zhiqwang changed the title Adapt to the Windows platform Fix Windows compatibility for TensorRT C++ example Apr 14, 2022
@zhiqwang zhiqwang added the bug / fix Something isn't working label Apr 14, 2022
@zhiqwang zhiqwang merged commit e5f80f0 into zhiqwang:main Apr 14, 2022
This was referenced Apr 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqwang zhiqwang zhiqwang approved these changes

Assignees
No one assigned
Labels
bug / fix Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows TensorRT C++ example compatibility
4 participants
@Yoh-Z @CLAassistant @ShiquanYu @zhiqwang