Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling path dependence in notebooks #84

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Conversation

zhiqwang
Copy link
Owner

This is a follow-up PR of #82 .

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #84 (290b933) into master (3087993) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   81.76%   81.97%   +0.20%     
==========================================
  Files           8        8              
  Lines         735      738       +3     
==========================================
+ Hits          601      605       +4     
+ Misses        134      133       -1     
Flag Coverage Δ
unittests 81.97% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_image_utils.py 100.00% <100.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3087993...290b933. Read the comment docs.

@zhiqwang zhiqwang added the documentation Improvements or additions to documentation label Mar 26, 2021
@zhiqwang zhiqwang changed the title Cleanup parameters in Notebooks Decoupling path dependence in notebooks Mar 29, 2021
@zhiqwang zhiqwang merged commit 2aaee95 into master Mar 29, 2021
@zhiqwang zhiqwang deleted the update-notebooks branch March 29, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant