Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fixes for Windows #13

Merged
merged 4 commits into from Apr 20, 2016
Merged

Build fixes for Windows #13

merged 4 commits into from Apr 20, 2016

Conversation

gboor
Copy link
Contributor

@gboor gboor commented Apr 18, 2016

Added and removed some headers to make this build on Windows 10 with VS 2015.

@zhm
Copy link
Owner

zhm commented Apr 18, 2016

Thanks for this! It looks like the build failed on Linux with the typeinfo removal.

Can you try fixing that by only skipping it on Windows?

#ifndef _MSC_VER
#include <typeinfo>
#endif

@gboor
Copy link
Contributor Author

gboor commented Apr 18, 2016

Should be fixed now

@gboor
Copy link
Contributor Author

gboor commented Apr 19, 2016

I see the test is still failing, but it appears this is because of some coffeescript error?

@zhm zhm merged commit 3e7c552 into zhm:master Apr 20, 2016
@zhm
Copy link
Owner

zhm commented Apr 20, 2016

✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gboor @zhm