Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crypto adapters and domains attach support #10

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

bjzhangl
Copy link
Contributor

No description provided.

Copy link
Contributor

@jiangphcn jiangphcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just would you like to add one function call in sample.go?

@huoqifeng
Copy link
Contributor

@bjzhangl may you please add snip code in sample for the new function as @jiangphcn mentioned, thanks!

@bjzhangl bjzhangl changed the title Add crypto adapters and domains attach support Add crypto adapters and domains attach support(DO NOT MERGE) Oct 31, 2023
@bjzhangl
Copy link
Contributor Author

bjzhangl commented Nov 1, 2023

@bjzhangl may you please add snip code in sample for the new function as @jiangphcn mentioned, thanks!

Sure.

Signed-off-by: zhangli <bjzhangl@cn.ibm.com>
@bjzhangl bjzhangl changed the title Add crypto adapters and domains attach support(DO NOT MERGE) Add crypto adapters and domains attach support Nov 6, 2023
@bjzhangl
Copy link
Contributor Author

bjzhangl commented Nov 6, 2023

@huoqifeng @jiangphcn i add sample code, please help review.

Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huoqifeng
Copy link
Contributor

Thanks! @bjzhangl

@huoqifeng huoqifeng merged commit f89f6aa into zhmcclient:master Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants