Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sustanability support #7

Merged
merged 1 commit into from
Oct 17, 2023
Merged

add sustanability support #7

merged 1 commit into from
Oct 17, 2023

Conversation

jiangphcn
Copy link
Contributor

@jiangphcn jiangphcn commented Oct 16, 2023 •
edited
Loading

Provide functionalities to get sustainability data.

huoqifeng
huoqifeng reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jiangphcn added several comments.

sample.go Outdated Show resolved Hide resolved
pkg/zhmcclient/lpar.go Outdated Show resolved Hide resolved
add sustanability support
2fca841 
Signed-off-by: Peng Hui Jiang <jiangph@cn.ibm.com>
huoqifeng
huoqifeng approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit 6bb10a7 into master Oct 17, 2023
1 check passed
@huoqifeng huoqifeng deleted the add-sustanability-support branch October 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huoqifeng huoqifeng huoqifeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiangphcn @huoqifeng