Skip to content

Commit

Permalink
Details:
Browse files Browse the repository at this point in the history
* Added support for a new make target 'authors' that generates an AUTHORS.md
  file from the git commit history. (issue #1393)

Signed-off-by: Anil Kumar Dakarapu <anil.kumar.dakarapu@ibm.com>
  • Loading branch information
Anil Kumar Dakarapu authored and andy-maier committed Jan 28, 2024
1 parent da07dd5 commit 3e451ef
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 6 deletions.
29 changes: 29 additions & 0 deletions AUTHORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Authors of this project

Sorted list of authors derived from git commit history:
```
ANDREW C. BREZOVSKY <abrezov@us.ibm.com>
ANDREW C. BREZOVSKY <abrezovsky@gmail.com>
Abhiram Santhosh <abhiram.santhosh1@ibm.com>
Alexander Egorenkov <egorenar@linux.ibm.com>
Andreas Maier <andreas.r.maier@gmx.de>
Andreas Maier <andy-maier@users.noreply.github.com>
Andreas Maier <maiera@de.ibm.com>
Andreas Scheuring <andreas.scheuring@de.ibm.com>
Andrew Brezovsky <abrezov@us.ibm.com>
Anil Kumar Dakarapu <anil.kumar.dakarapu@ibm.com>
Edwin Günthner <53468311+EdGue42@users.noreply.github.com>
Edwin Günthner <edwin.guenthner@de.ibm.com>
Juergen Leopold <leopoldj@de.ibm.com>
Kavin Raj A M <Kavin.Raj.A.M1@ibm.com>
Marc Hartmayer <mhartmay@de.ibm.com>
Marc Hartmayer <mhartmay@linux.ibm.com>
Markus Zoeller <mzoeller@de.ibm.com>
Sebastian Mitterle <smitterl@redhat.com>
Shreejit <shreejitnair18@gmail.com>
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
leopoldjuergen <leopoldj@de.ibm.com>
marcos <marcos.araque.fiallos@ibm.com>
sree <sree@192.168.1.100>
```
11 changes: 11 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ help:
@echo " all - Do all of the above"
@echo " end2end - Run end2end tests (adds to coverage results)"
@echo " end2end_show - Show HMCs defined for end2end tests"
@echo " authors - Generate AUTHORS.md file from git log"
@echo " uninstall - Uninstall package from active Python environment"
@echo " upload - Upload the distribution files to PyPI"
@echo " clean - Remove any temporary files"
Expand Down Expand Up @@ -628,6 +629,16 @@ end2end_mocked: Makefile $(done_dir)/develop_$(pymn)_$(PACKAGE_LEVEL).done $(pac
-bash -c "TESTEND2END_LOAD=true TESTINVENTORY=examples/example_hmc_inventory.yaml TESTVAULT=examples/example_hmc_vault.yaml py.test --color=yes $(pytest_no_log_opt) -v -s $(test_dir)/end2end $(pytest_cov_opts) $(pytest_opts)"
@echo "Makefile: $@ done."

.PHONY: authors
authors: _check_version
echo "# Authors of this project" >AUTHORS.md
echo "" >>AUTHORS.md
echo "Sorted list of authors derived from git commit history:" >>AUTHORS.md
echo '```' >>AUTHORS.md
git shortlog --summary --email | cut -f 2 | sort >>AUTHORS.md
echo '```' >>AUTHORS.md
@echo '$@ done.'

.PHONY: end2end_show
end2end_show:
bash -c "TESTEND2END_LOAD=true $(PYTHON_CMD) -c 'from zhmcclient.testutils import print_hmc_definitions; print_hmc_definitions()'"
5 changes: 5 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ Released: not yet
* Test: Added Python 3.8 with latest package levels to normal tests because
that is now the minimum version to run Sphinx. (related to issue #1396)

* Added support for a new make target 'authors' that generates an AUTHORS.md
file from the git commit history. Added the invocation of 'make authors' to
the description of how to release a version in the development
documentation. (issue #1393)

**Cleanup:**

**Known issues:**
Expand Down
18 changes: 12 additions & 6 deletions docs/development.rst
Original file line number Diff line number Diff line change
Expand Up @@ -788,14 +788,20 @@ local clone of the python-zhmcclient Git repo.
add text for any known issues you want users to know about.
* Remove all empty list items.

6. Commit your changes and push the topic branch to the remote repo:
6. Update the authors:

.. code-block:: sh
make authors
7. Commit your changes and push the topic branch to the remote repo:

.. code-block:: sh
git commit -asm "Release ${MNU}"
git push --set-upstream origin release_${MNU}
7. On GitHub, create a Pull Request for branch ``release_M.N.U``.
8. On GitHub, create a Pull Request for branch ``release_M.N.U``.

Important: When creating Pull Requests, GitHub by default targets the
``master`` branch. When releasing based on a stable branch, you need to
Expand All @@ -810,19 +816,19 @@ local clone of the python-zhmcclient Git repo.
tests for all defined environments, since it discovers by the branch name
that this is a PR for a release.

8. On GitHub, once the checks for that Pull Request have succeeded, merge the
9. On GitHub, once the checks for that Pull Request have succeeded, merge the
Pull Request (no review is needed). This automatically deletes the branch
on GitHub.

If the PR did not succeed, fix the issues.

9. On GitHub, close milestone ``M.N.U``.
10. On GitHub, close milestone ``M.N.U``.

Verify that the milestone has no open items anymore. If it does have open
items, investigate why and fix. If the milestone does not have open items
anymore, close the milestone.

10. Publish the package
11. Publish the package

.. code-block:: sh
Expand All @@ -838,7 +844,7 @@ local clone of the python-zhmcclient Git repo.
Github, and finally creates a new stable branch on Github if the master
branch was released.

11. Verify the publishing
12. Verify the publishing

Wait for the "publish" workflow for the new release to have completed:
https://github.com/zhmcclient/python-zhmcclient/actions/workflows/publish.yml
Expand Down

0 comments on commit 3e451ef

Please sign in to comment.