Renovate logging #106
Merged
Renovate logging #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details:
- Changed the logging so that it can now reasonably be used together
with other projects that use logging. This is done by
centralizing the log_init() function in the utils module, and
by changing it such that the log level is alwqys set, but the
file handler is set only when a log file is specified. As a result,
the loggers now propagate to the Python root logger when the
log_file parameter is not set.
So playbooks using the zhmc modules have two choices:
- Specify a log file via the log_file parameter
- Do not specify a log file and configure the Python root
logger as needed.
- Added log_file support to all modules that did not have it yet.
- Changed the format of log messages from:
%(asctime)s %(name)s %(message)s
with the default date format (e.g. 2019-02-20 10:54:26,123)
To:
%(asctime)s %(levelname)s %(name)s %(process)d %(message)s
with the default date format (e.g. 2019-02-20 10:54:26,123)
to be more in sync with common log formats.
- Removed the unused log() function in the utils module because
logging is now done directly to Python loggers.
Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/renovate-logging
branch
from
051287b
to
d80c974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.