Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version_added fields for sanity test #238

Merged
merged 1 commit into from Nov 13, 2020

Conversation

andy-maier
Copy link
Member

See commit message.

@andy-maier andy-maier self-assigned this Nov 13, 2020
@andy-maier andy-maier added this to the 1.0.0 milestone Nov 13, 2020
@andy-maier andy-maier linked an issue Nov 13, 2020 that may be closed by this pull request
Details:

* The version_added values so far were of the form M.N which causes
  the new ansible sanity test to complain. So far, these complaints
  were ignored in the ignore file for ansible 2.10. It turns out
  that this can be addressed by using the semver format M.N.U.
  This change does that, adds missing version_added fields where
  needed, and removes the corresponding entries in the Ansible 2.10
  ignore file.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Copy link
Contributor

@vkathir82 vkathir82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version changes are looking good to me

@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.457% when pulling a5087ca on andy/fix-version-added into a45695a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.457% when pulling a5087ca on andy/fix-version-added into a45695a on master.

@andy-maier andy-maier merged commit 8dc2d5a into master Nov 13, 2020
@andy-maier andy-maier deleted the andy/fix-version-added branch November 13, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove disabling of version_added check
3 participants