Skip to content

Commit

Permalink
Moved 'make safety' to the end of the test workflow
Browse files Browse the repository at this point in the history
This avoids hiding real issues discovered by the other test steps behind
the regularly occurring safety issues.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
  • Loading branch information
andy-maier committed Sep 26, 2023
1 parent c99fb1c commit a11f606
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,6 @@ jobs:
run: |
echo "Package dependency tree of installed Python packages:"
pipdeptree --all
- name: Run safety
env:
PACKAGE_LEVEL: ${{ matrix.package_level }}
run: |
make safety
- name: Run check_reqs
env:
PACKAGE_LEVEL: ${{ matrix.package_level }}
Expand Down Expand Up @@ -242,6 +237,11 @@ jobs:
COVERALLS_SERVICE_NUMBER: "${{ github.workflow }}-${{ github.run_number }}"
run: |
if ! [[ ${{ matrix.python-version }} =~ (3.4) ]]; then coveralls; fi
- name: Run safety
env:
PACKAGE_LEVEL: ${{ matrix.package_level }}
run: |
make safety
test_finish:
needs: test
Expand Down

0 comments on commit a11f606

Please sign in to comment.