Skip to content

Commit

Permalink
Fixed type of --disk-partition-id option in "lpar scsi-load/scsi-dump"
Browse files Browse the repository at this point in the history
Details:

* Fixed that the "lpar scsi-load" and "lpar scsi-dump" commands defined their
  --disk-partition-id option value incorrectly as a string, when it should have
  been an integer. (issue #270)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
  • Loading branch information
andy-maier committed Mar 25, 2022
1 parent 598d7b4 commit b129a0c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions docs/changes.rst
Expand Up @@ -30,6 +30,10 @@ Released: not yet

**Bug fixes:**

* Fixed that the "lpar scsi-load" and "lpar scsi-dump" commands defined their
--disk-partition-id option value incorrectly as a string, when it should have
been an integer. (issue #270)

**Enhancements:**

**Cleanup:**
Expand Down
4 changes: 2 additions & 2 deletions zhmccli/_cmd_lpar.py
Expand Up @@ -338,7 +338,7 @@ def lpar_psw_restart(cmd_ctx, cpc, lpar, **options):
@click.option('--load-parameter', type=str, required=False,
help='Provides additional control over the outcome of a '
'Load operation. Default: empty')
@click.option('--disk-partition-id', type=str, required=False,
@click.option('--disk-partition-id', type=int, required=False,
help='Provides boot program selector. Default: 0')
@click.option('--operating-system-specific-load-parameters', type=str,
required=False, help='Provides specific load parameters. '
Expand Down Expand Up @@ -382,7 +382,7 @@ def lpar_scsi_load(cmd_ctx, cpc, lpar, load_address, wwpn, lun, **options):
@click.option('--load-parameter', type=str, required=False,
help='Provides additional control over the outcome of a '
'Load operation. Default: empty')
@click.option('--disk-partition-id', type=str, required=False,
@click.option('--disk-partition-id', type=int, required=False,
help='Provides boot program selector. Default: 0')
@click.option('--operating-system-specific-load-parameters', type=str,
required=False, help='Provides specific load parameters. '
Expand Down

0 comments on commit b129a0c

Please sign in to comment.