Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using --vlan-id on "zhmc nic create" fails because vlan-type is required as well #292

Closed
andy-maier opened this issue Sep 27, 2022 · 0 comments · Fixed by #293 or #294
Closed

Using --vlan-id on "zhmc nic create" fails because vlan-type is required as well #292

andy-maier opened this issue Sep 27, 2022 · 0 comments · Fixed by #293 or #294
Assignees
@andy-maier
Labels
area: code resolution: fixed rollback done type: bug
Milestone
1.3.0

Comments

@andy-maier
Copy link
Member

... but is not supported in the currnet set of options
@andy-maier andy-maier self-assigned this Sep 27, 2022
@andy-maier andy-maier added this to the 1.3.0 milestone Sep 27, 2022
@andy-maier andy-maier changed the title Using --vlan-id on "zhmc nic create" fails because vlan-type s required as well Using --vlan-id on "zhmc nic create" fails because vlan-type is required as well Sep 27, 2022
andy-maier added a commit that referenced this issue Sep 28, 2022
@andy-maier
Fixed issues with --vlan-id on nic create/update
69fd12b 
Details:

* Fixed that --vlan-id could not be ommitted in 'zhmc nic create' and
  'zhmc nic update'. (issue #291)

* Fixed that the 'vlan-type' property was not set in the HMC request
  when --vlan-id was used in 'zhmc nic create'. (issue #292)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@andy-maier andy-maier linked a pull request Sep 28, 2022 that will close this issue
Fixed issues with --vlan-id on nic create/update #293
Merged
andy-maier added a commit that referenced this issue Sep 28, 2022
@andy-maier
Fixed issues with --vlan-id on nic create/update
b12039d 
Details:

* Fixed that --vlan-id could not be ommitted in 'zhmc nic create' and
  'zhmc nic update'. (issue #291)

* Fixed that the 'vlan-type' property was not set in the HMC request
  when --vlan-id was used in 'zhmc nic create'. (issue #292)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@andy-maier andy-maier linked a pull request Sep 28, 2022 that will close this issue
1.2: Fixed issues with --vlan-id on nic create/update #294
Merged
andy-maier added a commit that referenced this issue Sep 28, 2022
@andy-maier
Fixed issues with --vlan-id on nic create/update
e353d97 
Details:

* Fixed that --vlan-id could not be ommitted in 'zhmc nic create' and
  'zhmc nic update'. (issue #291)

* Added a '--vlan-type' option to 'zhmc nic create' and 'zhmc nic update' to
  set the VLAN type. (issue #292)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier added a commit that referenced this issue Sep 28, 2022
@andy-maier
Fixed issues with --vlan-id on nic create/update
a9b7cc5 
Details:

* Fixed that --vlan-id could not be ommitted in 'zhmc nic create' and
  'zhmc nic update'. (issue #291)

* Added a '--vlan-type' option to 'zhmc nic create' and 'zhmc nic update' to
  set the VLAN type. (issue #292)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier added a commit that referenced this issue Sep 28, 2022
@andy-maier
Fixed issues with --vlan-id on nic create/update
c0af936 
Details:

* Fixed that --vlan-id could not be ommitted in 'zhmc nic create' and
  'zhmc nic update'. (issue #291)

* Added a '--vlan-type' option to 'zhmc nic create' and 'zhmc nic update' to
  set the VLAN type. (issue #292)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier added a commit that referenced this issue Sep 28, 2022
@andy-maier
Fixed issues with --vlan-id on nic create/update
467f649 
Details:

* Fixed that --vlan-id could not be ommitted in 'zhmc nic create' and
  'zhmc nic update'. (issue #291)

* Added a '--vlan-type' option to 'zhmc nic create' and 'zhmc nic update' to
  set the VLAN type. (issue #292)

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-maier andy-maier

Labels
area: code resolution: fixed rollback done type: bug
Projects
None yet
Milestone
1.3.0
1 participant
@andy-maier