Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It could be more convenient to use annotations to indicate whether a pagelet is a barrier or a pipe #2

Closed
ltebean opened this issue Jan 16, 2015 · 2 comments

Comments

@ltebean
Copy link

ltebean commented Jan 16, 2015

No description provided.

@ltebean
Copy link
Author

ltebean commented Jan 16, 2015

There is even no need to use an annotation, since pagelet type can be decided when the base view gets parsed('pb-pipe' or 'pb-barrier')

@zhongliangjun1
Copy link
Owner

Now in plumber-1.2.0-SNAPSHOT , a pagelet (barrier or pipe) no longer need to implement the specific interface. Just extending the abstract class of PlumberPagelet, plumber will get the pagelet type by parsing the view source('pb-pipe' or 'pb-barrier').

Thanks for the suggestion. And the adjustment of the code is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants