New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc]: add 3.7 #274
[doc]: add 3.7 #274
Conversation
@seognil Thanks! I need some time to learn. Can you rebase the code on to master branch? I see some small merging conflicts exist. |
@zhongsp done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seognil Please fix the typo, then we're ready for merging! Thanks!
doc/release-notes/TypeScript 3.7.md
Outdated
@@ -0,0 +1,848 @@ | |||
# TypeScript 3.7 | |||
|
|||
## 可选链(Optional Chining) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: should be Chaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhongsp fixed (and some other stuff)
but I saw link problems in SUMMARY.md
preface.md
README.md
while checking links
Should I make a quick fix for these three files just in this PR or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge the main content first. The links are not big problemt. :D
finish #267
I made some serious effort (maybe 10 hours ?) for understanding and words using
thanks to this by the way
https://jkchao.github.io/typescript-book-chinese/new/typescript-3.7.html
(But I thought some parts are bit weird or maybe even wrong, could be improved)
Would you guys like to make a review, in case of misunderstanding
@zhongsp (as the translator of this repo)
@jkchao (as the translator of TypeScript Deep Dive)