Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]: add 3.7 #274

Merged
merged 6 commits into from Jan 15, 2020
Merged

[doc]: add 3.7 #274

merged 6 commits into from Jan 15, 2020

Conversation

seognil
Copy link
Contributor

@seognil seognil commented Jan 12, 2020

finish #267

I made some serious effort (maybe 10 hours ?) for understanding and words using
thanks to this by the way
https://jkchao.github.io/typescript-book-chinese/new/typescript-3.7.html
(But I thought some parts are bit weird or maybe even wrong, could be improved)

Would you guys like to make a review, in case of misunderstanding
@zhongsp (as the translator of this repo)
@jkchao (as the translator of TypeScript Deep Dive)

@zhongsp
Copy link
Owner

zhongsp commented Jan 14, 2020

@seognil Thanks! I need some time to learn. Can you rebase the code on to master branch? I see some small merging conflicts exist.

@seognil
Copy link
Contributor Author

seognil commented Jan 14, 2020

@zhongsp done

Copy link
Owner

@zhongsp zhongsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seognil Please fix the typo, then we're ready for merging! Thanks!

@@ -0,0 +1,848 @@
# TypeScript 3.7

## 可选链(Optional Chining)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be Chaining

Copy link
Contributor Author

@seognil seognil Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongsp fixed (and some other stuff)
but I saw link problems in SUMMARY.md preface.md README.md while checking links

Should I make a quick fix for these three files just in this PR or later

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge the main content first. The links are not big problemt. :D

@zhongsp zhongsp merged commit e4cd938 into zhongsp:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants