Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] test file must end with _test. #14

Merged
merged 2 commits into from
Nov 29, 2016
Merged

[bug] test file must end with _test. #14

merged 2 commits into from
Nov 29, 2016

Conversation

zhongwencool
Copy link
Owner

@zhongwencool zhongwencool commented Nov 29, 2016 •
edited
Loading

  1. fix test/maxwell/builder_exception_test.exs never run....
    test case must end with XXX_test.exs
  2. add json exceptions test case.
  3. add logger exceptions test case.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.6%) to 97.857% when pulling c4aee3e on fixed-testcase into 9ae7beb on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.0%) to 99.286% when pulling c1adb20 on fixed-testcase into 9ae7beb on master.

@zhongwencool
Copy link
Owner Author

@secretworry 99%！！！！！！！！！

@zhongwencool zhongwencool merged commit dbb74b9 into master Nov 29, 2016
@zhongwencool zhongwencool deleted the fixed-testcase branch November 29, 2016 15:26
@secretworry
Copy link
Collaborator

Woo! 1% from perfection~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zhongwencool zhongwencool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongwencool @coveralls @secretworry