Fix internal consistency issues. See #30 #31

bitwalker · 2017-01-15T02:49:27Z

See our previous discussion on #30

This PR touches many modules, but all changes are relatively small. If you have any concerns about any of them, let me know and I can try to explain in more detail.

Adapters now return Maxwell.Conn.t instead of {:ok, Maxwell.Conn.t}
Middleware are now unified around returning Maxwell.Conn.t instead of
{:ok, Maxwell.Conn.t}
Fix broken Rels middleware
Update and add missing typespecs
Update tests (and fix test warnings on newer Erlang/Elixir versions)
A few documentation tweaks, spelling, etc.

The gist is the following:

Existing third-party middleware modules should not need to make any changes
Third-party adapter modules will need to ensure they return Maxwell.Conn.t instead of {:ok, Maxwell.Conn.t}, this is a breaking change, but essential to fix the internal consistency issues.
Existing built-in middlewares that were previously broken are now working as expected.

- Adapters now return Maxwell.Conn.t instead of {:ok, Maxwell.Conn.t} - Middleware are now unified around returning Maxwell.Conn.t instead of {:ok, Maxwell.Conn.t} - Fix broken Rels middleware - Update and add missing typespecs - Update tests - A few documentation tweaks, spelling, etc.

coveralls · 2017-01-15T02:52:41Z