Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in StringWithUint16Perfix, StringWithUint32Perfix etc. #5

Closed
jazz-sh opened this issue Jul 21, 2017 · 3 comments
Closed

Typos in StringWithUint16Perfix, StringWithUint32Perfix etc. #5

jazz-sh opened this issue Jul 21, 2017 · 3 comments

Comments

@jazz-sh
Copy link
Contributor

jazz-sh commented Jul 21, 2017 •
edited
Loading

Hello,

The following functions have typos in them. They should end in Prefix, not Perfix

  • StringWithUint16Perfix
  • StringWithUint32Perfix
  • StringWithUint64Perfix
  • BytesWithUint16Perfix
  • BytesWithUint32Perfix
  • BytesWithUint64Perfix
@zhuangsirui
Copy link
Owner

so bad, it's a incompatible change :(

@jazz-sh
Copy link
Contributor Author

jazz-sh commented Jul 24, 2017

I have proposed a fix.
#6

I am happy to change the comments to a style that suits you to mark the functions as deprecated.

zhuangsirui added a commit that referenced this issue Jul 24, 2017
@zhuangsirui
Merge pull request #6 from jazz-sh/issue_5_fix
49c3a7d 
Fix issue #5
@zhuangsirui
Copy link
Owner

Great PR, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhuangsirui @jazz-sh