Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the output sameplerate match the input #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 21, 2015

  1. Make the output sameplerate match the input

    There are 3 arguments that are passed into the `Mp3Encoder` (channels,
    samplerate and kbps).
    
    The input samplerate is generally dependant on `AudioContext.sampleRate` and
    this varies from machine-to-machine.
    
    I was having resampling issues until I make the output samplerate match the
    input samplerate. Now everything is OK and I get what I am expecting from my
    encoded audio.
    
    A note to others who may read this, ensure that you use the sample rate
    provided from `AudioContext` if you're encoding audio from the users mic in
    order to avoid strange resampling issues (different pitch, playback rate etc)
    Darryn Ten committed Sep 21, 2015
    Configuration menu
    Copy the full SHA
    77bbb2c View commit details
    Browse the repository at this point in the history