Fix audio being cut off in mic.html worker example #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MDN docs on createScriptProcessor recommends developers allow the browser to choose the best bufferSize. It seems large buffer sizes reduce the load but also reduce quality. Prior to this commit the maximum possible buffer size was chosen and that seemed to result in the last part of the audio being clipped off in the recording. Also worth noting is that apparently the ScriptProcessorNode was deprecated in 2014 but the replacement, Audio Workers, has yet to be implemented in any browsers.
|
ping to @zhuker? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDN docs on createScriptProcessor recommends developers allow the browser to choose
the best bufferSize. It seems large buffer sizes reduce the load
but also reduce quality. Prior to this commit the maximum possible buffer size was chosen
and that seemed to result in the last part of the audio being clipped off in the recording.
Also worth noting is that apparently the ScriptProcessorNode was deprecated in 2014
but the replacement, Audio Workers, has yet to be implemented in any browsers.
closes #36 I created