-
Notifications
You must be signed in to change notification settings - Fork 2.4k
update-angular.sh replaced by git submodule #41
Comments
I'd rather propose to use grunt or gulp and bower. Let me know if I should create a feature branch. |
@metalmatze What the advantages of your proposal compared with a git submodule? |
Well. Bower is a package manager for frontend libraries. Http://Bower.io |
I've quickly read about bower and it's not still clear to me why it's better than just a git submodule in this case. The more dependencies you have to deploy an app, more complicated would be for developers to have it up and running. |
@metalmatze I personally think that Bower is an overkill for this project. In future I'll try to exclude as many library dependencies as possible (except for AngularJS and some crypto stuff, of course), and currently some of them have my edits. So I think, that git submodule fits better, for this purpose. But I consider adding some build tool to make some work with Angular templates, concatenating/minifying scripts etc, compiling CoffeeScript. Please share your opinion if you have some thoughts. |
Based on my personal experience, I have two concerns about this: 1- I mean, each person who clones the code, must be able to do "node server.js" right after cloning code. No previous, "grunt build" or whatever. This ensures that people non familiarized with those tools could get the project running as easier as it is right now. 2 - Again, this is just my personal thoughts on this. I've already make this to minify the scripts: grep -o 'src="[^"]"' index.html | sed 's/src=//' | sed 's/?[0-9]//' | sed 's/"$/" /' | tr -d "\n" | xargs uglifyjs > app/app.js But adding this to makefile will add an extra dependency on uglifyjs anyway, and can be handled on a better way and more flexible with grunt-usemin (I've no experience with Gulp) or some angular-related plugin. |
1-
First task may be completed by using packaged releases (https://github.com/zhukov/webogram/releases), even if build is rather complicated. But the second task may require build process in many cases. We can try to avoid them, e.g. using usemin and coffeescript in-brower compiler etc, but it's not that easy. So it may require Grunt/Gulp in the future. 2- I personally liked Gulp description more, but never used it. I've found all the required plugins:
So I think as soon, as I deal with current problems I can start implementing it. Or may be anyone else if he'd like to do it earlier. |
I've never used gulp on a real project yet. I'll make some initial config using those plugins during the weekend and send a PR. I would also recommend jshint and imagemin (from #58) |
update-angular.sh downloads the latest angular version, but this should be done using a git submodule to app/vendor/angular it's proper and cleaner ;)
http://git-scm.com/book/en/Git-Tools-Submodules
The text was updated successfully, but these errors were encountered: