Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

UI messaging for slow key generation #320

Merged
merged 1 commit into from
Jun 19, 2014

Conversation

jimCresswell
Copy link
Contributor

Added messaging to the login form to indicate that key generation may take a long time on slow devices. This does not fix the slow key generation but does adjust expectations so it should not be frustrating. Fix #40.

… take a long time on slow devices. This does not fix the slow key generation but does adjust expectations so it should not be frustrating. Fix zhukov#40.
@jimCresswell
Copy link
Contributor Author

I'd prefer to keep it simple and not introduce a delay, I don't think anyone is going to mind seeing a message saying it might take time and then getting the keys fast, they'd probably feel quite pleased with themselves. On the other hand diligently waiting five seconds and then being told you have to wait more might be annoying.

If we do want to introduce a delay in the messaging I would prefer to do it in CSS and work the Angular classes, something like

.my-div.ng-hide-remove {
  transition:3s step-end all;
}
.my-div {
  height: auto;
  opacity:1;
}
.my-div.ng-hide {
  height: 0;
  opacity: 0;
}

@zhukov , any thoughts?

@zhukov
Copy link
Owner

zhukov commented Jun 16, 2014

Thanks for the PR. I think that css animation is reasonable. I will merge this soon.

@zhukov zhukov merged commit acb024f into zhukov:master Jun 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Firefox OS] Fails to connect on Firefox OS < 1.2
3 participants