Skip to content

Commit

Permalink
refactor: [user] role entity 이름 변경
Browse files Browse the repository at this point in the history
Role -> RoleEntity

issue key : #78
  • Loading branch information
zhyunk committed May 1, 2024
1 parent 9b68624 commit 462811f
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 29 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package kim.zhyun.serveruser.config.model;

import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
Expand All @@ -19,7 +19,7 @@ public class UserDto {
private String nickname;
private String password;
private boolean withdrawal;
private Role role;
private RoleEntity role;
private LocalDateTime modifiedAt;


Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package kim.zhyun.serveruser.domain.member.controller.model;

import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
Expand All @@ -16,7 +16,7 @@ public class UserResponse {
private Long id;
private String email;
private String nickname;
private Role role;
private RoleEntity role;



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import kim.zhyun.serveruser.domain.member.controller.model.UserResponse;
import kim.zhyun.serveruser.domain.member.repository.UserEntity;
import kim.zhyun.serveruser.domain.signup.controller.model.SignupRequest;
import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import lombok.RequiredArgsConstructor;
import org.springframework.security.crypto.password.PasswordEncoder;
import org.springframework.stereotype.Component;
Expand Down Expand Up @@ -33,12 +33,12 @@ public UserDto toDto(UserEntity source) {
.modifiedAt(source.getModifiedAt()).build();
}

public UserEntity toEntity(SignupRequest request, Role role) {
public UserEntity toEntity(SignupRequest request, RoleEntity roleEntity) {
return UserEntity.builder()
.email(request.getEmail())
.nickname(request.getNickname())
.password(passwordEncoder.encode(request.getPassword()))
.role(role)
.roleEntity(roleEntity)
.build();
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package kim.zhyun.serveruser.domain.member.repository;

import jakarta.persistence.*;
import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import lombok.*;
import org.springframework.data.annotation.CreatedDate;
import org.springframework.data.annotation.LastModifiedDate;
Expand Down Expand Up @@ -42,6 +42,7 @@ public class UserEntity {

@ManyToOne
private Role role;
private RoleEntity role;

@Override
public boolean equals(Object o) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import kim.zhyun.serveruser.domain.member.controller.model.UserUpdateRequest;
import kim.zhyun.serveruser.domain.member.repository.UserEntity;
import kim.zhyun.serveruser.domain.member.repository.UserRepository;
import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import kim.zhyun.serveruser.domain.signup.repository.RoleRepository;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
Expand Down Expand Up @@ -152,8 +152,8 @@ public UserDetails loadUserByUsername(String username) throws UsernameNotFoundEx
* 회원 권한 설정
*/
private void userSetRole(UserEntity userEntity, String roleType) {
Role role = roleRepository.findByGrade(roleType);
userEntity.setRole(role);
RoleEntity roleEntity = roleRepository.findByGrade(roleType);
userEntity.setRole(roleEntity);
userEntity.setWithdrawal(TYPE_WITHDRAWAL.equals(roleType));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import kim.zhyun.serveruser.domain.signup.converter.EmailAuthConverter;
import kim.zhyun.serveruser.domain.signup.converter.NicknameReserveConverter;
import kim.zhyun.serveruser.domain.signup.converter.SessionUserConverter;
import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import kim.zhyun.serveruser.domain.signup.repository.SessionUser;
import kim.zhyun.serveruser.domain.signup.service.EmailService;
import kim.zhyun.serveruser.domain.signup.service.NicknameReserveService;
Expand Down Expand Up @@ -138,10 +138,10 @@ public String saveMember(String sessionId, SignupRequest request) {
|| !sessionUser.getNickname().equals(request.getNickname()))
throw new ApiException(EXCEPTION_REQUIRE_NICKNAME_DUPLICATE_CHECK);

Role role = signUpService.getGrade(sessionUser.getEmail());
RoleEntity roleEntity = signUpService.getGrade(sessionUser.getEmail());

// 신규 user 등록
UserEntity savedUser = signUpService.saveUser(userConverter.toEntity(request, role));
UserEntity savedUser = signUpService.saveUser(userConverter.toEntity(request, roleEntity));

// redis user info 저장소 업데이트
signUpService.jwtUserInfoUpdate(savedUser);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
package kim.zhyun.serveruser.domain.signup.repository;


import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.Id;
import jakarta.persistence.*;
import lombok.Getter;

import java.util.Objects;

import static jakarta.persistence.GenerationType.IDENTITY;

@Getter
@Entity
public class Role {
@Entity(name = "role")
public class RoleEntity {

@Id @GeneratedValue(strategy = IDENTITY)
private Long id;
Expand All @@ -25,10 +22,10 @@ public class Role {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof Role role)) return false;
return Objects.equals(getId(), role.getId())
&& Objects.equals(getGrade(), role.getGrade())
&& Objects.equals(getDescription(), role.getDescription());
if (!(o instanceof RoleEntity roleEntity)) return false;
return Objects.equals(getId(), roleEntity.getId())
&& Objects.equals(getGrade(), roleEntity.getGrade())
&& Objects.equals(getDescription(), roleEntity.getDescription());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

import java.util.List;

public interface RoleRepository extends Repository<Role, Long> {
public interface RoleRepository extends Repository<RoleEntity, Long> {

List<Role> findAll();
Role findByGrade(String grade);
List<RoleEntity> findAll();
RoleEntity findByGrade(String grade);
boolean existsByGrade(String grade);

}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import kim.zhyun.jwt.domain.repository.JwtUserInfoRepository;
import kim.zhyun.serveruser.domain.member.repository.UserEntity;
import kim.zhyun.serveruser.domain.member.repository.UserRepository;
import kim.zhyun.serveruser.domain.signup.repository.Role;
import kim.zhyun.serveruser.domain.signup.repository.RoleEntity;
import kim.zhyun.serveruser.domain.signup.repository.RoleRepository;
import lombok.RequiredArgsConstructor;
import org.apache.logging.log4j.util.Strings;
Expand Down Expand Up @@ -35,7 +35,7 @@ public boolean isUsedNickname(String nickname) {
return userRepository.existsByNicknameIgnoreCase(nickname);
}

public Role getGrade(String email) {
public RoleEntity getGrade(String email) {
// admin 유저 구분
String admins = Strings.join(adminEmails, ',');
String grade = admins == null || !admins.contains(email)
Expand Down

0 comments on commit 462811f

Please sign in to comment.