Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook rework for smoke tests #60

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Notebook rework for smoke tests #60

merged 10 commits into from
Oct 23, 2023

Conversation

matthewcarbone
Copy link
Collaborator

@matthewcarbone matthewcarbone commented Oct 20, 2023

Resolves #53.

@matthewcarbone matthewcarbone added the enhancement New feature or request label Oct 20, 2023
@matthewcarbone matthewcarbone added this to the v0.2 milestone Oct 20, 2023
@matthewcarbone matthewcarbone self-assigned this Oct 20, 2023
@matthewcarbone matthewcarbone marked this pull request as draft October 20, 2023 20:36
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #60 (80853eb) into main (83c0113) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   95.98%   96.01%   +0.02%     
==========================================
  Files          44       44              
  Lines        3541     3541              
==========================================
+ Hits         3399     3400       +1     
+ Misses        142      141       -1     
Flag Coverage Δ
unittests 96.01% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matthewcarbone
Copy link
Collaborator Author

Handled about half of the notebooks. Should decrease the testing time significantly but I could be wrong since I'm running on different hardware locally. Let's see how long it takes now.

@ziatdinovmax ziatdinovmax marked this pull request as ready for review October 23, 2023 14:48
Copy link
Owner

@ziatdinovmax ziatdinovmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the notebook test time has been reduced by a factor of 2

@ziatdinovmax ziatdinovmax merged commit 77e1bf6 into main Oct 23, 2023
12 checks passed
@matthewcarbone
Copy link
Collaborator Author

@ziatdinovmax great! Take a quick look at them too when you can too. I did make some QOL changes, made the plots a bit clearer, etc.

@matthewcarbone matthewcarbone deleted the mc-dev-notebooks branch October 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement faster smoke tests of notebooks
3 participants