Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FC for Twig TokenParserInterface #66

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

erik-zicht
Copy link
Contributor

@erik-zicht erik-zicht commented Nov 16, 2022

Method "Twig\TokenParser\TokenParserInterface::getTag()" might add "string" as a native return type declaration in the future. Do the same in implementation "Zicht\Bundle\FrameworkExtraBundle\Twig\ControlStructures\StrictTokenParser" now to avoid errors or add an explicit @return annotation to suppress this message.

@7ochem
Copy link
Contributor

7ochem commented Nov 18, 2022

bdfb310 "bump" ? 😄

@erik-zicht
Copy link
Contributor Author

bdfb310 "bump" ? smile

Ja ik kreeg een force-commit niet binnen in een test-project, toen had ik maar een nieuwe gemaakt 🤷‍♂️

@erik-zicht erik-zicht merged commit 948ad7c into release/10.x Nov 18, 2022
@erik-zicht erik-zicht deleted the fc-twig--1 branch November 18, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants