Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui white flash at start up #125

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: ui white flash at start up #125

merged 1 commit into from
Mar 26, 2024

Conversation

dagregi
Copy link
Contributor

@dagregi dagregi commented Mar 23, 2024

It seems removing the background color fixes the bug metioned in #114

@zifeo zifeo requested a review from Yohe-Am March 23, 2024 10:39
@Yohe-Am
Copy link
Collaborator

Yohe-Am commented Mar 23, 2024

Nice solution. My retinas will appreciate this. Does this solve the hang issue though? The flash lasts for around 500ms+ which seems excessive. White or not, would be nice to get rid of that. If not possible in this PR, let's keep the ticket around.

@dagregi
Copy link
Contributor Author

dagregi commented Mar 24, 2024

I tried it on different devices to see if it is a device specific bug but there were no noticable delay.

@Yohe-Am
Copy link
Collaborator

Yohe-Am commented Mar 26, 2024

Sorry on late reply. I usually work on SSH, which exacerbates things I suppose. Or maybe it's the commands I am using...hmm

@zifeo zifeo merged commit fb634cd into zifeo:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants