Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add test result] Need to change min and max available value for the test-date field. #4

Closed
julia-aksyanova opened this issue Sep 2, 2020 · 1 comment

Comments

@julia-aksyanova
Copy link
Collaborator

Severity:
enhancement

Build info:
0505970

Overview:
Need to add the limitation for the test-date field in the add-test-result command (
zblcli tx compliancetest add-test-result --vid= --pid= --test-result= --test-date= --from=).
Actually, the test-date field has the following limits:

  • minimum available value is equal to 1000-01-01T00:00:00Z;
  • maximum available value is equal to 9999-12-31T23:59:59Z.

It is suggested to change these limitations for the following values that must be discussed:

  • minimum available value is equal to 1900-01-01T00:00:00Z;
  • maximum available value is equal to 1999-12-31T23:59:59Z.
@ashcherbakov ashcherbakov added this to the v0.3 milestone Sep 10, 2020
@ashcherbakov ashcherbakov added this to Backlog in DCL Sep 10, 2020
adenishchenko pushed a commit that referenced this issue Nov 6, 2020
ashcherbakov added a commit that referenced this issue Nov 9, 2020
* Fixed revoke for invalid `vid` & `pid`

* Fixed linter errors

* FIx linter errors #2

* fix

* Fix linter errors #3

* Fix linter errors #4

* Fixed integration tests, linter issues

* Fixed linter issue

Co-authored-by: anton <anton@DenishchenkoA.vi.ubuntu.dsr-corporation.com>
Co-authored-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
@ashcherbakov ashcherbakov removed this from the v0.3 milestone Nov 1, 2021
@ashcherbakov ashcherbakov removed this from Backlog in DCL Feb 9, 2022
ashcherbakov pushed a commit that referenced this issue Apr 13, 2022
* scaffolded ProposeDisableValidator
and ApproveDisableValidator types

* updated cli commands

* added ProposedDisableValidator

* scaffolded DisabledValidator

* corrected REST endpoints

* improved NotFound error processing

* msg_server updated

* refactoring

* linted

* query commands improved

* tests updated

* disable validator msg added

* msg_server updated

* scaffolded EnableValidator

* tx's improved

* msg_server updated

* compilation errors and test errors fixed

* handler tests updated

* scripts fixed

* ProposedDisableValidator and DisabledValidator

* bugs fixed

* linted

* validations for validator msgs added

* message validations updated

* tests updated

* validations added

* docs updated

* grant added

* Grant support added

* Jailing added

* updated query

* roles refactoring

* messages enable/disable validator updated

* validator message ValidateBasic updated

* bug fixed

* added more checks

* tests updated

* msg_server updated

* tests updated

* msg_server updated

* handler_test updated

* validation added

* redundant code removed

* added integration test

* integration tests for validators added

* added validator tests

* fixed address convertation

* cli commands updated

* integration tests added

* docs updated

* validator cli integration tests updated
@ashcherbakov
Copy link
Contributor

Test Results are not stored in DCL anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants