Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators: Revocation #41

Closed
ashcherbakov opened this issue Sep 10, 2020 · 2 comments
Closed

Validators: Revocation #41

ashcherbakov opened this issue Sep 10, 2020 · 2 comments
Assignees
Labels

Comments

@ashcherbakov ashcherbakov added this to the v0.3 milestone Sep 10, 2020
@ashcherbakov ashcherbakov removed this from the v0.3 milestone Nov 1, 2021
@ashcherbakov ashcherbakov added this to the v0.7: Main Net Launch milestone Feb 9, 2022
@ashcherbakov ashcherbakov added size: M enhancement New feature or request labels Feb 9, 2022
@DenisRybas
Copy link
Collaborator

DenisRybas commented Mar 2, 2022

Everything will be implemented as described in ticket (using instructions from How To Make Changes in Data Model for Existing Modules and How To Add a new Module) and docs, but there will be some changes:

  1. The changes for unjail_validator_node:
    • unjail_validator_node will be renamed to enable_validator_node
    • required role Trustee will be changed to NodeAdmin;owner
  2. The changes for remove_validator_node, propose_remove_validator_node, approve_remove_validator_node:
    • will be renamed to disable_validator_node, propose_disable_validator_node, approve_disable_validator_node

The docs will be changed in accordance with what is described above

@abdulla-ashurov
Copy link
Collaborator

abdulla-ashurov commented Apr 14, 2022

Everything will be implemented as described in ticket (using instructions from How To Make Changes in Data Model for Existing Modules and How To Add a new Module) and docs, but there will be some changes:

  1. The changes for unjail_validator_node:
  • unjail_validator_node will be renamed to enable_node

  • required role Trustee will be changed to NodeAdmin;owner

  1. The changes for remove_validator_node, propose_remove_validator_node, approve_remove_validator_node:
    will be renamed to disable_node, propose_disable_node, approve_disable_node

  2. Add unit and integration tests for checking owner NodeAdmin can not add second a new Validator when owner NodeAdmin's validator was disabled.

The docs will be changed in accordance with what is described above

Corresponding PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants