Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple Models Info with the same VID/PID but different versions #75

Closed
ashcherbakov opened this issue Nov 9, 2020 · 1 comment
Projects

Comments

@ashcherbakov
Copy link
Contributor

ashcherbakov commented Nov 9, 2020

Acceptance criteria:

  • Vendors need to be able to publish new versions of the same model (same VID/PID combination).
  • New versions are identified by a combination of firmware_version and hardware_version,
  • Every new version is published in non-certified state. So, Test Results publishing and compliance certification need to specify firmware_version and hardware_version in addition to pid and vid.
  • hardware_version can be an optional field in the future

Technical tasks:

  • vid/pid/hw_ver/fw_ver needs to be a key for ModelInfos, Compliance tests and certifications results
  • There needs to be an index for the vid/pid to a list of versions
  • GET_MODEL_INFO by VID/PID returns a list of all versions of the model
  • There needs to be a way to get a particular version of the model info by specifying vid, pid, firmware_version and hardware_version. It can be either a new command, or a query parameter to the existing GET_MODEL_INFO command.
  • GET_ALL_MODEL_INFO and GET_VENDOR_MODEL_INFO need to return firmware_version and hardware_version fields
  • firmware_version and hardware_version fields needs to be included into ADD_TEST_RESULT and GET_TEST_RESULT
  • firmware_version and hardware_version fields needs to be included into CERTIFY_MODEL, REVOKE_MODEL_CERTIFICATION, GET_CERTIFIED_MODEL, GET_REVOKED_MODEL
@ashcherbakov ashcherbakov added this to the v0.3 milestone Nov 9, 2020
@ashcherbakov ashcherbakov added this to Backlog in DCL Nov 9, 2020
@ashcherbakov ashcherbakov moved this from Backlog to To do in DCL Nov 9, 2020
@ashcherbakov ashcherbakov moved this from To do to In progress in DCL Oct 15, 2021
@ashcherbakov
Copy link
Contributor Author

PR: #91

DCL automation moved this from In progress to Done Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
DCL
  
Done
Development

No branches or pull requests

1 participant