Schema Changes to match 0.7 Chip Spec #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Support for Device Versions and Vendor Info. p.s. TODO (Add some more test cases and updated documentation.)
ankur325
force-pushed
the
SchemaChanges_0.7
branch
from
eeae8f3
to
8e4a1b5
Compare
ankur325
force-pushed
the
SchemaChanges_0.7
branch
from
8e4a1b5
to
1b76450
Compare
Refactored and added support for matter in addition to zigbee
…ompliance-ledger into SchemaChanges_0.7
x/modelversion/handler_test.go
Outdated
| require.Equal(t, receivedModelVersion.SoftwareVersion, modelVersion.SoftwareVersion) | ||
| } | ||
|
|
||
| func TestHandler_UpdateModelVersion(t *testing.T) { |
There was a problem hiding this comment.
Please add a test where we create a model version with all fields, update only minimal set of fields (or no fields at all), and make sure that all fields untouched during update has initial values (are nor reset).
|
Thank you for these new features, improvements, and re-factorings!
|
ankur325
force-pushed
the
SchemaChanges_0.7
branch
from
689ba24
to
446ed71
Compare
ankur325
force-pushed
the
SchemaChanges_0.7
branch
from
7841962
to
0e6ce6b
Compare
…ompliance-ledger into SchemaChanges_0.7
…ompliance-ledger into SchemaChanges_0.7
…ompliance-ledger into SchemaChanges_0.7
ashcherbakov
approved these changes
Nov 2, 2021
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for Device Versions and Vendor Info.
p.s. TODO (Add some more test cases and updated documentation.)
I will add few more changes to this for documentation and test cases