#560 Enable removing NOC ICA certificates #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdulbois
force-pushed
the
#560-Enable-removing-ICA-certs
branch
2 times, most recently
from
a6b15c8
to
c90939e
Compare
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois
force-pushed
the
#560-Enable-removing-ICA-certs
branch
from
c90939e
to
9bde610
Compare
Enable actionlint job Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois
force-pushed
the
#560-Enable-removing-ICA-certs
branch
from
7d42a5f
to
3a7bac6
Compare
akarabashov
approved these changes
May 6, 2024
docs/transactions.md
Outdated
| @@ -1466,6 +1466,25 @@ Revoked certificates can be retrieved by using the [GET_REVOKED_CERT](#get_revok | |||
| - CLI command: | |||
| - `dcld tx pki revoke-noc-x509-ica-cert --subject=<base64 string> --subject-key-id=<hex string> --serial-number=<string> --info=<string> --time=<int64> --revoke-child=<bool> --from=<account>` | |||
|
|
|||
| #### REMOVE_NOC_IC | |||
There was a problem hiding this comment.
Suggested change
| #### REMOVE_NOC_IC | |
| #### REMOVE_NOC_ICA |
akarabashov
reviewed
May 6, 2024
|
|
||
| // Remove from ICA lists | ||
| removeCertFromList(certBySerialNumber.Issuer, certBySerialNumber.SerialNumber, &icaCerts.Certs) | ||
| k._removeNocX509IcaCert(ctx, certID, &icaCerts, msg.SerialNumber) |
There was a problem hiding this comment.
I believe that calling k.RemoveNocIcaCertificateBySerialNumber(ctx, certificates.Vid, certID.Subject, certID.SubjectKeyId, serialNumber) will be enough here
akarabashov
reviewed
May 6, 2024
| // Remove from Approved lists | ||
| aprCerts, _ := k.GetApprovedCertificates(ctx, msg.Subject, msg.SubjectKeyId) | ||
| removeCertFromList(certBySerialNumber.Issuer, certBySerialNumber.SerialNumber, &aprCerts.Certs) | ||
| k._removeApprovedX509Cert(ctx, certID, &aprCerts, msg.SerialNumber) |
There was a problem hiding this comment.
Maybe it would be better to move _removeApprovedX509Cert from msg_server_remove_x_509_cert file to a more generic file
akarabashov
reviewed
May 6, 2024
| } | ||
| if foundRevoked { | ||
| removeCertFromList(certBySerialNumber.Issuer, certBySerialNumber.SerialNumber, &revCerts.Certs) | ||
| k._removeRevokedX509Cert(ctx, certID, &revCerts) |
There was a problem hiding this comment.
Maybe it would be better to move _removeRevokedX509Cert from msg_server_remove_x_509_cert file to a more generic file
Move methods to more generic place Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois
force-pushed
the
#560-Enable-removing-ICA-certs
branch
from
184ca90
to
b694a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.