Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig.path has a default of null when it is declared as a string #157

Closed
tristan957 opened this issue Dec 12, 2023 · 0 comments · Fixed by #166
Closed

zig.path has a default of null when it is declared as a string #157

tristan957 opened this issue Dec 12, 2023 · 0 comments · Fixed by #166
Labels
enhancement

Comments

@tristan957
Copy link

https://github.com/ziglang/vscode-zig/blob/master/package.json#L106-L110

VSCode warns about this in a settings.json file. I think you probably want to either change the default to "zig" or "", or add "null" to the type attribute, which can be an array, fyi.
@yvvki yvvki mentioned this issue Jan 3, 2024
Closed
@alexrp alexrp mentioned this issue Jan 15, 2024
Merged
@Vexu Vexu closed this as completed in #166 Jan 16, 2024
Vexu pushed a commit that referenced this issue Jan 16, 2024
@alexrp @Vexu
Make zig.path and zig.zls.path default to "" (look up in PATH).
7c0c64d 
* These will be overwritten by the initial setup process anyway.
* This at least ensures that the default value doesn't cause a warning when editing `settings.json`.
* Looking these programs up in `PATH` seems like a sensible default and is consistent with many other extensions.

Closes #157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make zig.path and zig.zls.path default to "" (look up in PATH).
2 participants
@tristan957 @Vexu