-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add mask before truncating dereferenced bit pointers (#9584)
- Loading branch information
Showing
3 changed files
with
69 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
const std = @import("std"); | ||
|
||
const A = packed struct { | ||
a: bool, | ||
b: bool, | ||
c: bool, | ||
d: bool, | ||
|
||
e: bool, | ||
f: bool, | ||
g: bool, | ||
h: bool, | ||
}; | ||
|
||
const X = union { | ||
x: A, | ||
y: u64, | ||
}; | ||
|
||
pub fn a( | ||
x0: i32, | ||
x1: i32, | ||
x2: i32, | ||
x3: i32, | ||
x4: i32, | ||
flag_a: bool, | ||
flag_b: bool, | ||
) !void { | ||
_ = x0; | ||
_ = x1; | ||
_ = x2; | ||
_ = x3; | ||
_ = x4; | ||
_ = flag_a; | ||
// With this bug present, `flag_b` would actually contain the value 17. | ||
// Note: this bug only presents itself on debug mode. | ||
try std.testing.expect(@ptrCast(*const u8, &flag_b).* == 1); | ||
} | ||
|
||
pub fn b(x: *X) !void { | ||
try a(0, 1, 2, 3, 4, x.x.a, x.x.b); | ||
} | ||
|
||
test "bug 9584" { | ||
var flags = A{ | ||
.a = false, | ||
.b = true, | ||
.c = false, | ||
.d = false, | ||
|
||
.e = false, | ||
.f = true, | ||
.g = false, | ||
.h = false, | ||
}; | ||
var x = X{ | ||
.x = flags, | ||
}; | ||
try b(&x); | ||
} |