std/os/uefi: additional improvements/fixes

[fifty-six]

No description provided.

[Vexu]

Have you checked that the changes you made to padding don't affect the structs? Packed structs are still a bit buggy at the moment.

[fifty-six]

Yeah, I used zig test with this:

fn test_types(comptime TPrev: type, comptime TPost: type) void {
    var a = std.mem.zeroes(TPrev);
    var b = std.mem.zeroes(TPost);

    inline for (@typeInfo(TPost).Struct.fields) |field| {
        assert(@bitOffsetOf(TPrev, field.name) == @bitOffsetOf(TPost, field.name));
        assert(@offsetOf(TPrev, field.name) == @offsetOf(TPost, field.name));
    }

    assert(@sizeOf(TPrev) == @sizeOf(TPost));
    assert(@alignOf(@TypeOf(&a)) == @alignOf(@TypeOf(&b)));
}

test "align" {
    test_types(Time, Time2);
    test_types(AbsolutePointerMode, AbsolutePointerMode2);
    test_types(AbsolutePointerState, AbsolutePointerState2);
    test_types(EdidOverrideProtocolAttributes, EdidOverrideProtocolAttributes2);
    test_types(SimpleNetworkReceiveFilter, SimpleNetworkReceiveFilter2);
    test_types(SimpleNetworkInterruptStatus, SimpleNetworkInterruptStatus2);
    test_types(OpenProtocolAttributes, OpenProtocolAttributes2);

    var a = std.mem.zeroes(AbsolutePointerMode);
    var a2 = std.mem.zeroes(AbsolutePointerMode2);

    var b = std.mem.zeroes(AbsolutePointerState);
    var b2 = std.mem.zeroes(AbsolutePointerState2);

    test_types(@TypeOf(a.attributes), @TypeOf(a2.attributes));
    test_types(@TypeOf(b.active_buttons), @TypeOf(b2.active_buttons));
}

For the tests I changed _pad on the simplified versions to _pad1 so that it would check the offset against the old start of the padding.