test: improve test/batch sequence iterator and move all tests into cases/ parent dir #11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
approved these changes
May 4, 2022
With this improved iterator, type of test is now inferred from the filename, enabling us to put all cases in one common parent directory, and iterate over that, thus automating a lot of tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during our last stage2 meeting, I've improved filename parsing logic so that it is no longer necessary to explicitly specify testing strategy (
incrementalorindependent); instead, the harness will automatically infer it based on the file naming used (foo.0.zig,foo.1.zig, etc., will signify incremental updates, whilefoo.zigwill signify independent compilation).As a direct consequence of this, all compiler tests (compile errors, incremental updates) now share common root directory, and are placed within
test/cases/path.