safety: show error return trace when unwrapping error in switch #12889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
force-pushed
the
unwrap-error-switch
branch
from
21d1569
to
87abfc0
Compare
andrewrk
force-pushed
the
unwrap-error-switch
branch
from
87abfc0
to
537c25b
Compare
|
I rebased against latest master branch (2698cb3) now that the CI is fixed. |
andrewrk
force-pushed
the
unwrap-error-switch
branch
from
537c25b
to
d769d30
Compare
|
The previous CI run passed all checks except Windows. |
|
Still failing on Windows. I suggest to run std lib tests in debug mode locally on Windows. |
andrewrk
force-pushed
the
unwrap-error-switch
branch
from
d769d30
to
d7d2167
Compare
|
I re-ran the failed Windows test and it passed this time, so we can conclude that the problem affects master branch and was not introduced by this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12807 re-opened on a new branch to modify CI script.