stage2: Fix softfloat support for PPC64(LE) #13100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
powerpc64le
branch
3 times, most recently
from
a6fba9a
to
6ae9546
Compare
|
With these changes, I can now do: $ zig build --prefix $(pwd)/ppc64le -Dtarget=powerpc64le-linux
$ qemu-ppc64le ./ppc64le/bin/zig version
0.10.0-dev.4250+6ed73720a
$ qemu-ppc64le ./ppc64le/bin/zig test test/behavior.zig -I . -I test -target x86_64-linux
853 passed; 562 skipped; 0 failed.The behavior tests also pass (cross-compiling from x86-64): $ zig test test/behavior.zig -I . -I test -target powerpc64le-linux --test-cmd qemu-ppc64le --test-cmd-bin
...
1331 passed; 100 skipped; 0 failed.I haven't gone through the Zig bootstrap process for PPC, so I have not tested the LLVM backend on PowerPC. Likely there are still problems there due to the C ABI being incorrect/unimplemented for PPC. |
topolarity
force-pushed
the
powerpc64le
branch
from
3dd648a
to
aa27e4c
Compare
topolarity
commented
Oct 7, 2022
| } else if (common.want_aeabi) { | ||
| @export(__aeabi_h2f, .{ .name = "__aeabi_h2f", .linkage = common.linkage }); | ||
| } else { | ||
| @export(__extendhfsf2, .{ .name = "__extendhfsf2", .linkage = common.linkage }); | ||
| } |
There was a problem hiding this comment.
This exports the "standard compiler-rt" symbol names on all targets, since this is what stage2 calls for softfloat in the backend.
Let me know if this is wrong - We can make the softfloat calls to the arch-specific ABI instead of re-exporting.
topolarity
force-pushed
the
powerpc64le
branch
from
aa27e4c
to
0747b4c
Compare
andrewrk
approved these changes
Oct 11, 2022
topolarity
force-pushed
the
powerpc64le
branch
from
ab69f8a
to
4fd8d93
Compare
|
All good here. Let's see what the CI thinks. P.S. I almost regressed stage1 on accident with this PR - Might be worth re-enabling behavior tests on CI for stage1 until stage1 is gone, at least for one target. |
topolarity
force-pushed
the
powerpc64le
branch
3 times, most recently
from
954b28e
to
d2a4edf
Compare
Merged
This gets the behavior tests passing for stage1 again.
Stage 2's softfloat support still had a couple of gaps, which were preventing us from lowering `f16` on this target. With any luck, this is enough to get PPC64 working as a Tier 2 target again.
This change also exposes some of the existing functions under both the PPC-style names symbols and the compiler-rt-style names, since Zig currently lowers softfloat calls to the latter.
Also, f16 is not supported on this backend.
This instruction is not supported on this backend, so should just be a noop.
topolarity
force-pushed
the
powerpc64le
branch
from
060536f
to
3486322
Compare
Closed
topolarity
force-pushed
the
powerpc64le
branch
from
7e6fc24
to
a168893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With any luck, this is enough to get PPC64 compiling again.